Skip to content

Update JS dependencies #35759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 28, 2025
Merged

Update JS dependencies #35759

merged 5 commits into from
Oct 28, 2025
+445 −208

Conversation

@silverwind
Copy link
Member

@silverwind silverwind commented Oct 27, 2025 •
edited
Loading

  • Update all JS dependencies
  • Added new unicorn rules
  • updates now also supports updating packageManager and engines, and I see no reason not to do that, so I think we can try keeping these updated as well. If something in the build breaks because of this, I will revert and exclude pnpm from updating further, but as far as I understand, only corepack respects this field and pnpm itself does not care about it.
  • Regenerate SVGs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 27, 2025
@silverwind
Copy link
Member Author

According to https://pnpm.io/package_json#engines, pnpm does care about engines:

During local development, pnpm will always fail with an error message if its version does not match the one specified in the engines field.

So i guess I will revert this, given that some developers may run slightly older versions.

@silverwind
Copy link
Member Author

silverwind commented Oct 27, 2025 •
edited
Loading

So I think the best course forward is:

  • Keep engines.pnpm at the minimum supported version
  • Keep packageManager updated, this field is used and required by pnpm/action-setup (ref), unless we want to specify pnpm version in actions config.

I updated updates to no longer updated engines by default

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 28, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 28, 2025
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 28, 2025
@lunny lunny enabled auto-merge (squash) October 28, 2025 17:30
@lunny lunny merged commit d69eede into go-gitea:main Oct 28, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.26.0 milestone Oct 28, 2025
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 28, 2025
@silverwind silverwind deleted the deps-101 branch October 28, 2025 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lunny lunny lunny approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/dependencies modifies/frontend

Projects

None yet

Milestone

1.26.0

Development

Successfully merging this pull request may close these issues.

4 participants

@silverwind @lunny @wxiaoguang @GiteaBot